Re: [PATCH] backlight: ili922x: remove redundant variable len

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 06, 2017 at 01:06:46PM +0100, walter harms wrote:
> >>       tbuf[1] = set_tx_byte((value & 0xFF00) >> 8);
> >>
> 
> nitpick:
>  value is u16 so value >> 8 is sufficient

It's the same, yes, but the current code is more readable.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux