Hi Colin Thank you for the patch. On 29/10/17 14:43, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Pointer pix is being initialized to a value and a little later > being assigned the same value again. Remove the initial assignment to > avoid a duplicate assignment. Cleans up the clang warning: > > drivers/media/platform/sti/bdisp/bdisp-v4l2.c:726:26: warning: Value > stored to 'pix' during its initialization is never read > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Reviewed-by: Fabien Dessenne <fabien.dessenne@xxxxxx> > --- > drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > index 939da6da7644..7e9ed9c7b3e1 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > @@ -723,7 +723,7 @@ static int bdisp_enum_fmt(struct file *file, void *fh, struct v4l2_fmtdesc *f) > static int bdisp_g_fmt(struct file *file, void *fh, struct v4l2_format *f) > { > struct bdisp_ctx *ctx = fh_to_ctx(fh); > - struct v4l2_pix_format *pix = &f->fmt.pix; > + struct v4l2_pix_format *pix; > struct bdisp_frame *frame = ctx_get_frame(ctx, f->type); > > if (IS_ERR(frame)) { ��.n��������+%������w��{.n����z�ޗ�����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�