>> @@ -700,10 +700,9 @@ static int sr9800_phy_powerup(struct usbnet *dev)
>>
>> /* set the embedded Ethernet PHY in power-up state */
>> ret = sr_sw_reset(dev, SR_SWRESET_IPRL);
>> - if (ret < 0) {
>> - netdev_err(dev->net, "Failed to reset PHY: %d\n", ret);
>> - return ret;
>> - }
>> + if (ret < 0)
>> + goto report_reset_failure;
>
> So now I have to look below to see what error handling it does...
Yes. - Can this be an usual consequence if you apply information from
the section “7) Centralized exiting of functions” in the document
“coding-style.rst” a bit more?
> Hence I prefer the original version, which had _less_ lines of code...
My update suggestion is only one line “bigger” in this case, isn't it?
I propose an other source code layout so that a bit smaller executable
object code could be achieved.
Do find such a software design direction feasible?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
