On Fri, Oct 27, 2017 at 11:06:36AM +0200, Jules Maselbas wrote: > Hi, > > > We can't return directly in max3421_hub_control(), we have to unlock > > first. > Yes you are right. > I think testing if pdata is null is not necessary as driver_probe will fail if > the device do not have a platform_data. > In that case, let's drop my patch. Could you send a patch for which removes the NULL check and add a Reported-by: for me? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html