On Tue, Oct 24, 2017 at 01:11:07PM +0300, Jani Nikula wrote: > On Tue, 24 Oct 2017, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > We accidentally inverted an if statement and turned amd_powerplay_reset() > > into a no-op. > > > > Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in amd_powerplay.c (v3)") > > For some reason I looked up that commit, and it has *two* cases where > "ret != 0" gets changed to "!ret". > The other bug was secretly fixed in commit 3811f8f00c5f ("drm/amd/powerplay: move set_clockgating_by_smu to pp func table"). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html