On 2017년 10월 23일 14:45, SF Markus Elfring wrote: >> As you commented, this patch might remove the redundant error message. >> But, it makes the code more complicated in side of readability. > > Do you try to avoid duplicated code any more in other circumstances? I usually used the goto statement on following cases: - Return the value (error number if fail or 0 if success) - Do free or unregister or remove operations when error happen. I think that there is any benefit of this patch. Also, as I commented, it make the code more complicated. -- Best Regards, Chanwoo Choi Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html