From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 22 Oct 2017 14:10:33 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/crypto/ccp/sp-platform.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/ccp/sp-platform.c b/drivers/crypto/ccp/sp-platform.c
index 71734f254fd1..7d7670c7484a 100644
--- a/drivers/crypto/ccp/sp-platform.c
+++ b/drivers/crypto/ccp/sp-platform.c
@@ -78,25 +78,25 @@ static int sp_get_irqs(struct sp_device *sp)
sp_platform->irq_count = count;
ret = platform_get_irq(pdev, 0);
- if (ret < 0) {
- dev_notice(dev, "unable to get IRQ (%d)\n", ret);
- return ret;
- }
+ if (ret < 0)
+ goto report_failure;
sp->psp_irq = ret;
if (count == 1) {
sp->ccp_irq = ret;
} else {
ret = platform_get_irq(pdev, 1);
- if (ret < 0) {
- dev_notice(dev, "unable to get IRQ (%d)\n", ret);
- return ret;
- }
+ if (ret < 0)
+ goto report_failure;
sp->ccp_irq = ret;
}
return 0;
+
+report_failure:
+ dev_notice(dev, "unable to get IRQ (%d)\n", ret);
+ return ret;
}
static int sp_platform_probe(struct platform_device *pdev)
--
2.14.2
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
