Re: [PATCH] fat: remove redundant assignment of 0 to slots

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Colin King <colin.king@xxxxxxxxxxxxx> writes:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The variable slots is being assigned a value of zero that is never
> read, slots is being updated again a few lines later. Remove this
> redundant assignment.
> Cleans clang warning: Value stored to 'slots' is never read
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Looks like good (if old gcc didn't have false positive warning).

Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>

> ---
>  fs/fat/dir.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index 81cecbe6d7cf..b833ffeee1e1 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -291,7 +291,6 @@ static int fat_parse_long(struct inode *dir, loff_t *pos,
>  		}
>  	}
>  parse_long:
> -	slots = 0;
>  	ds = (struct msdos_dir_slot *)*de;
>  	id = ds->id;
>  	if (!(id & 0x40))

-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux