On Thu, Oct 12, 2017 at 2:21 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> Hello Wei Wang,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 66f5d6ce53e6: "ipv6: replace rwlock with rcu and spinlock
> in fib6_table" from Oct 6, 2017, leads to the following Smatch
> complaint:
>
> net/ipv6/ip6_fib.c:1462 fib6_locate()
> warn: variable dereferenced before check 'fn' (see line 1459)
>
> net/ipv6/ip6_fib.c
> 1458 if (src_len) {
> 1459 struct fib6_node *subtree = FIB6_SUBTREE(fn);
> ^^^^^^^^^^^^^^^^
> We shifted this dereference
>
> 1460
> 1461 WARN_ON(saddr == NULL);
> 1462 if (fn && subtree)
> ^^
> before the check for NULL.
Hi Dan,
Thanks for the report. Yes. It does seem like an issue. I will send an
upstream patch to fix this.
>
> 1463 fn = fib6_locate_1(subtree, saddr, src_len,
> 1464 offsetof(struct rt6_info, rt6i_src),
>
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
