On Wed, 4 Oct 2017, Alexander Sverdlin wrote:
> Hello Markus,
>
> On Wed, 4 Oct 2017 20:45:14 +0200
> SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> > Omit an extra message for a memory allocation failure in this function.
> >
> > This issue was detected by using the Coccinelle software.
>
> what exactly has the software detected?
> I cannot find, how this error is reported otherwise, it seems
> to me that the message is not that superflous.
>
> The patches 2..4 look to me as an exercise without any practical meaning.
> Indeed, that's not how new code should be posted, but if we start
> rewriting all the legacy code, this will produce huge and completely
> unnecessary patch traffic.
kmalloc etc will produce a backtrace on failure that will provide
essentially the same information.
I don't know what was in the other patches, but the useless assignments to
err in these functions are perhaps worth fixing.
julia
>
> > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > ---
> > arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 2 --
> > arch/cris/arch-v32/drivers/mach-fs/nandflash.c | 2 --
> > 2 files changed, 4 deletions(-)
> >
> > diff --git a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> > index 925a98eb6d68..259aa1f46fbe 100644
> > --- a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> > +++ b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> > @@ -136,8 +136,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
> > /* Allocate memory for MTD device structure and private data */
> > wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
> > if (!wrapper) {
> > - printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD "
> > - "device structure.\n");
> > err = -ENOMEM;
> > return NULL;
> > }
> > diff --git a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> > index 53b56a429dde..1baf16ee74e8 100644
> > --- a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> > +++ b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> > @@ -111,8 +111,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
> > /* Allocate memory for MTD device structure and private data */
> > wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
> > if (!wrapper) {
> > - printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD "
> > - "device structure.\n");
> > err = -ENOMEM;
> > return NULL;
> > }
>
> --
> Alexander Sverdlin.
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
