From: Colin King <colin.king@xxxxxxxxxxxxx> Date: Sun, 1 Oct 2017 17:27:35 +0100 > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > In the unlikely event that mfc->mfc_un.res.ttls[i] is 255 for all > values of i from 0 to MAXIVS-1, the err is not set at all and hence > has a garbage value on the error return at the end of the function, > so initialize it to 0. Also, the error return check on err and goto > to err: inside the for loop makes it impossible for err to be zero > at the end of the for loop, so we can remove the redundant err check > at the end of the loop. > > Detected by CoverityScan CID#1457207 ("Unitialized scalar value") > > Fixes: c011ec1bbfd6 ("mlxsw: spectrum: Add the multicast routing offloading logic") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Applied. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html