On Fri, 2017-08-25 at 17:32 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate arrays on the stack, instead make them static .
> Makes the object code smaller by 76 bytes:
>
> Before:
> text data bss dec hex
> filename
> 4217 1540 128 5885 16fd
> arch/x86/platform/intel-mid/pwr.o
>
> After:
> text data bss dec hex
> filename
> 3981 1700 128 5809 16b1
> arch/x86/platform/intel-mid/pwr.o
Fine by me.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> arch/x86/platform/intel-mid/pwr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/platform/intel-mid/pwr.c
> b/arch/x86/platform/intel-mid/pwr.c
> index ef03852ea6e8..49ec5b94c71f 100644
> --- a/arch/x86/platform/intel-mid/pwr.c
> +++ b/arch/x86/platform/intel-mid/pwr.c
> @@ -444,7 +444,7 @@ static int mid_set_initial_state(struct mid_pwr
> *pwr, const u32 *states)
> static int pnw_set_initial_state(struct mid_pwr *pwr)
> {
> /* On Penwell SRAM must stay powered on */
> - const u32 states[] = {
> + static const u32 states[] = {
> 0xf00fffff, /* PM_SSC(0) */
> 0xffffffff, /* PM_SSC(1) */
> 0xffffffff, /* PM_SSC(2) */
> @@ -455,7 +455,7 @@ static int pnw_set_initial_state(struct mid_pwr
> *pwr)
>
> static int tng_set_initial_state(struct mid_pwr *pwr)
> {
> - const u32 states[] = {
> + static const u32 states[] = {
> 0xffffffff, /* PM_SSC(0) */
> 0xffffffff, /* PM_SSC(1) */
> 0xffffffff, /* PM_SSC(2) */
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
