On Thu, Aug 24, 2017 at 11:55:10PM +0300, Dan Carpenter wrote: > This is just cleanups and doesn't change the behavior. You can't return from in the middle of the loop just because the allocation fails. > The static checker is still going to complain about the error pointer > from the loop. Please drop this argument about the static checker which you write. I'm certainly not changing code just because some tool complains. > Perhaps we should only set prev_found if the memdup_patch() > inside the loop succeeds? This not why we set prev_found. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html