Re: [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 22, 2017 at 10:05:37PM +0200, SF Markus Elfring wrote:
> >> @@ -1121,30 +1121,27 @@ static int snd_via82xx_create(struct snd_card *card,
> >>  
> >>  	if ((err = pci_request_regions(pci, card->driver)) < 0) {
> >>  		kfree(chip);
> >> -		pci_disable_device(pci);
> >> -		return err;
> >> +		goto disable_device;

Ah, you're right.  It's not leaking.  I thought you deleted the
kfree(chip);...

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux