On 15/08/17 16:22, Dan Carpenter wrote: > On Tue, Aug 15, 2017 at 05:38:34PM +0300, Mika Westerberg wrote: >> On Tue, Aug 15, 2017 at 03:31:33PM +0100, Colin King wrote: >>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx> >>> >>> req->response_type is being assigned the sizeof TB_CFG_PKG_RESET >>> and should actually be assigned TB_CFG_PKG_RESET. Fix this. >>> >>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> >> >> IIRC I already acked this some time ago ;-) >> >> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> >> >> BTW, you should CC Greg as he has been gathering Thunderbolt related >> patches. I added him now. > > Yeah. I sent this patch on Jun 14. "[PATCH] thunderbolt: Fix reset > response_type" I didn't CC Greg, either. Someone should probably > update MAINTAINERS if Greg needs to get these emails. > > Colin, could you please add Fixes tags to your patches? Will do. > It helps me > investigate how bugs are introduced. I know we all had a long thread > and agreed to not add them if the patch probably doesn't fix a user > visible bug, but this one is clearly a bugfix. Since you fixed this back in Jun, will you re-send your original fix? Colin > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
