Re: [PATCH net] mcs7780: Silence uninitialized variable warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 29, 2017 at 11:28:55PM -0700, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Date: Fri, 28 Jul 2017 17:45:11 +0300
> 
> > -	__u16 rval;
> > +	__u16 rval = -1;
> 
> Fixing a bogus warning by assigning a signed constant to an
> unsigned variable doesn't really make me all that happy.
> 
> I don't think I'll apply this, sorry.

There's no guarantee that small kmallocs will always succeed in future
kernels so it's not *totally* bogus.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux