RE: [PATCH 2/2] scsi: aacraid: Off by one NUL terminator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Dave,
> 
> > The issue is that we are making an inquiry response from
> > container/RAID info. We could also have included a "pad" byte to
> > terminate the string, as the fib data is 512 bytes. My assumption is
> > that somehow back in the day, someone managed to get odd characters
> > into the name.
> >
> > Terminating the string early would truncate the name ...
> 
> So what do you propose as a fix?

We can add the pad byte to the struct, and terminate the string there. I'm out the office now, but Raghava or I will send up a patch ... That way, folks won't need to contemplate what appears to be a blatant out of bounds reference.

-Dave
> 
> --
> Martin K. Petersen      Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux