On Tue, Feb 21, 2017 at 10:42 PM, Tobin C. Harding <me@xxxxxxxx> wrote: > Coccinelle emits WARNING: casting value returned by memory allocation > function to (struct proc_inode *) is useless. > > Remove unnecessary cast. > > Signed-off-by: Tobin C. Harding <me@xxxxxxxx> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx> -Kees > --- > fs/proc/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/proc/inode.c b/fs/proc/inode.c > index 842a5ff..1eb2326 100644 > --- a/fs/proc/inode.c > +++ b/fs/proc/inode.c > @@ -57,7 +57,7 @@ static struct inode *proc_alloc_inode(struct super_block *sb) > struct proc_inode *ei; > struct inode *inode; > > - ei = (struct proc_inode *)kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL); > + ei = kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL); > if (!ei) > return NULL; > ei->pid = NULL; > -- > 2.7.4 > -- Kees Cook Pixel Security -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
