Once again in plain text, only - sorry for frogetting to set the switch in my mailtool.... Hi Dan, Hi Walter, thank you for your investigation. rf69_get_modulation, rf69_get_lna_gain, rf69_set_lna_gain: Seems like I messed up a few things :-/ In the beginning, the defines were left-bound "real" values, like you can see for the LNA_GAIN values. Later on, I deceided not to use left-bound "real" values, but to leave the bits at the position, they have in the register. These two impelemtation types are mixed up here. Sorry. Result: The shift is obsolete and the LNA_GAIN defines are old-style and need to be reviesed. I will send a patch with a proposal in approx. half an hour. rf69_set_deviation: Yes Dan, bitwise negate was intended. Once again, thanks a lot for your investigation, Marcus Thanks a lot, Marcus > Dan Carpenter <dan.carpenter@xxxxxxxxxx> hat am 19. Juli 2017 um 12:26 > geschrieben: > > > Actually, please drop this patch. I looked at this one the same as I > did the other one, but I didn't look closely enough. It's the same > situation where we have two bugs that probably cancel each other out > somewhat. It maybe needs to be fixed by someone who can test the code. > > In rf69_set_lna_gain() we should be left shifting << 3 but we don't. > > regards, > dan carpenter > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
