[PATCH] platform/x86: peaq-wmi: silence a static checker warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Static checkers complain because:

	if (peaq_ignore_events_counter && --peaq_ignore_events_counter >= 0)
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The second part of the condition is always true because
"peaq_ignore_events_counter" is unsigned.  It doesn't cause a problem
because the first part of the condition prevents underflows, but it's
simple enough to make the static checker happy.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

diff --git a/drivers/platform/x86/peaq-wmi.c b/drivers/platform/x86/peaq-wmi.c
index 77d1f90b0794..ab5d5b060587 100644
--- a/drivers/platform/x86/peaq-wmi.c
+++ b/drivers/platform/x86/peaq-wmi.c
@@ -20,7 +20,7 @@
 
 MODULE_ALIAS("wmi:"PEAQ_DOLBY_BUTTON_GUID);
 
-static unsigned int peaq_ignore_events_counter;
+static int peaq_ignore_events_counter;
 static struct input_polled_dev *peaq_poll_dev;
 
 /*
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux