On Thu, Jul 13, 2017 at 01:53:10PM -0400, Chuck Lever wrote: > > > On Jul 13, 2017, at 1:51 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote: > > > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > > > The current check will always be true and will always jump to > > err1, this looks dubious to me. I believe && should be used > > instead of ||. > > > > Detected by CoverityScan, CID#1450120 ("Logically Dead Code") > > > > Fixes: 107c1d0a991a ("svcrdma: Avoid Send Queue overflow") > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Reviewed-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > > Dan reported this today, and I have a similar patch in my > "pending for-rc" series. This one works too. Applied and merged upstream, thanks. --b. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html