On Thu, Jul 13, 2017 at 10:47:22AM +0300, Dan Carpenter wrote:
> We accidentally forgot to set the error code if ib_copy_from_udata()
> fails. It means we return ERR_PTR(0) which is NULL and results in a
> NULL dereference in the callers.
>
> Fixes: d37498417947 ("i40iw: add files for iwarp interface")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_verbs.c b/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> index 4dbe61ec7a77..91f1631ff32d 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> @@ -1161,8 +1161,10 @@ static struct ib_cq *i40iw_create_cq(struct ib_device *ibdev,
> memset(&req, 0, sizeof(req));
> iwcq->user_mode = true;
> ucontext = to_ucontext(context);
> - if (ib_copy_from_udata(&req, udata, sizeof(struct i40iw_create_cq_req)))
> + if (ib_copy_from_udata(&req, udata, sizeof(struct i40iw_create_cq_req))) {
> + err_code = -EFAULT;
> goto cq_free_resources;
> + }
>
> spin_lock_irqsave(&ucontext->cq_reg_mem_list_lock, flags);
> iwpbl = i40iw_get_pbl((unsigned long)req.user_cq_buffer,
Nice catch. Thank you!
Acked-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
