On 12/07/17 07:49, Stanislaw Gruszka wrote: > On Tue, Jul 11, 2017 at 12:47:33PM +0100, Colin King wrote: >> From: Colin Ian King <colin.king@xxxxxxxxxxxxx> >> >> Don't populate array glrt_table on the stack but make it static. >> Makes the object code a smaller by over 670 bytes: >> >> Before: >> text data bss dec hex filename >> 131772 4733 0 136505 21539 rt2800lib.o >> >> After: >> text data bss dec hex filename >> 131043 4789 0 135832 21298 rt2800lib.o >> >> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Acked-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > I wonder why compiler do not optimize by itself since array is > const, but patch is ok. Afraid marking it as const does not guarantee that at all. The const qualifier just announces that the value will not be changed [1]. So one requires static const to ensure it's not populated on the stack and also marked as non-modifiable. [1] Section A4.4, The C programming Language, page 196 Colin > > Stanislaw > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
