On Mon, Jul 10, 2017 at 5:08 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Don't populate arrays on the stack but make them static. Makes > the object code smaller. Also remove temporary variables that > have hard coded array sizes and just use ARRAY_SIZE instead and > wrap some lines that are wider than 80 chars to clean up some > checkpatch warnings. > > Before: > text data bss dec hex filename > 11141 2008 64 13213 339d drivers/char/mwave/smapi.o > > After: > text data bss dec hex filename > 10697 2352 64 13113 3339 drivers/char/mwave/smapi.o > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Acked-by: Arnd Bergmann <arnd@xxxxxxxx> Did you use a particular tool that found these variables? I assume you are not actually using the driver ;-) -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html