On Mon, Jul 10, 2017 at 12:38:16PM +0300, Dan Carpenter wrote: > There were two buggy commits so I chose the ealier one. The other buggy No, you are mistaken. In the original patch, NULL or PTR_ERR were returned on error, and that was not a bug. If you want to correct the present version of ptp_clock_register() to always return a valid pointer or PTR_ERR (like the kerneldoc says), be my guest, but please say that in the change log and reference the correct commit (namely the one related to disabling POSIX clocks.) Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html