From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Date: Fri, 7 Jul 2017 06:56:16 +0200 > If this memory allocation fails, we should go through the error handling > path as done everywhere else in this function before returning. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> This is really the tip of the iceberg here and this function's cleanup really needs to be shored up more completely than this. If the allocation of 'card' succeeds, and one of the "goto out_port" paths are taken, 'card' is leaked because the last thing performed is linking it into the list inside of 'priv'. Anyways, I'll apply this but there are so many more leaks here. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html