On Wed, 2017-07-05 at 13:15 -0500, Mike Christie wrote: > On 07/04/2017 03:44 AM, Colin King wrote: > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > > > Variables device_mutex and device_list static are local to the source, > > so make them static. > > > > Cleans up sparse warnings: > > "symbol 'device_list' was not declared. Should it be static?" > > "symbol 'device_mutex' was not declared. Should it be static?" > > > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > --- > > drivers/target/target_core_device.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c > > index 3ae8fbf01bdf..bbcef3bc66c8 100644 > > --- a/drivers/target/target_core_device.c > > +++ b/drivers/target/target_core_device.c > > @@ -49,8 +49,8 @@ > > #include "target_core_pr.h" > > #include "target_core_ua.h" > > > > -DEFINE_MUTEX(device_mutex); > > -LIST_HEAD(device_list); > > +static DEFINE_MUTEX(device_mutex); > > +static LIST_HEAD(device_list); > > static DEFINE_IDR(devices_idr); > > > > static struct se_hba *lun0_hba; > > > > My fault. Thanks. > > Reviewed-by: Mike Christie <mchristi@xxxxxxxxxx> Applied. Thanks Colin + MNC. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html