From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Wed, 28 Jun 2017 14:44:21 +0300 > My static checker complains that ofdpa_neigh_del() can sometimes free > "found". It just makes sense to use it first before deleting it. > > Fixes: ecf244f753e0 ("rocker: fix maybe-uninitialized warning") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Applied, thanks. > Most ref counting function use atomic_dec() but ofdpa_neigh_del() just > uses normal decrement. Are you sure this isn't racy? A spinlock is held always when this counter is touched. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html