walter harms, on mer. 28 juin 2017 16:49:03 +0200, wrote: > Am 28.06.2017 15:13, schrieb Colin King: > > diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c > > index 442f191a017e..ed8e96b06ead 100644 > > --- a/drivers/staging/speakup/spk_ttyio.c > > +++ b/drivers/staging/speakup/spk_ttyio.c > > @@ -21,7 +21,7 @@ struct spk_ldisc_data { > > static struct spk_synth *spk_ttyio_synth; > > static struct tty_struct *speakup_tty; > > > > -int ser_to_dev(int ser, dev_t *dev_no) > > +static int ser_to_dev(int ser, dev_t *dev_no) > > { > > if (ser < 0 || ser > (255 - 64)) { > > pr_err("speakup: Invalid ser param. Must be between 0 and 191 inclusive.\n"); > > > Is there any remark, why the programmer decided to use (255 - 64) instead of 191 ? That's because minor numbers for ttyS* are starting from 64. Samuel -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html