Re: [PATCH] iio: adc: mxs-lradc: Checking IS_ERR() instead of NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 13 Jun 2017 11:39:05 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> On Thu, Apr 27, 2017 at 07:21:09AM +0100, Jonathan Cameron wrote:
> > On 26/04/17 22:03, Dan Carpenter wrote:  
> > > devm_ioremap() returns NULL on error.  It doesn't return error pointers.
> > > 
> > > Fixes: 6dd112b9f85e ("iio: adc: mxs-lradc: Add support for ADC driver")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > >   
> > Hi Dan,
> > 
> > Already another patch for this under review.  Open question there is whether
> > devm_ioremap_resource is the way to go instead.
> >   
> 
> I wasn't on that other thread...  Nothing appears to have happened with
> this or the touchscreen bug either.
> 
> regards,
> dan carpenter
I think I was just being a bit lax in actually pushing it out and sending
Greg a pull request. 

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=1454e15bc28ba94aa5d6b31a83a42d5c03af2a6d

Thanks for following up on this.

Jonathan
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux