On Tue, Jun 20, 2017 at 01:56:35PM +0530, Vivek Gautam wrote: > > > On 06/19/2017 04:26 PM, Dan Carpenter wrote: > > We want to timeout with try set to zero so this should be a pre-op > > instead of post-op. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > diff --git a/drivers/phy/broadcom/phy-brcm-sata.c b/drivers/phy/broadcom/phy-brcm-sata.c > > index ccbc3d994998..48fb016ce689 100644 > > --- a/drivers/phy/broadcom/phy-brcm-sata.c > > +++ b/drivers/phy/broadcom/phy-brcm-sata.c > > @@ -329,7 +329,7 @@ static int brcm_nsp_sata_init(struct brcm_sata_port *port) > > /* Wait for pll_seq_done bit */ > > try = 50; > > - while (try--) { > > + while (--try) { > > Do we want to try reading the status 50 times? If yes, won't your change > break that? It will rather run the loop 49 times. > Yeah. I know. I'm pretty sure that 50 is a rough number, and not an exact thing. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html