Re: [PATCH] x86/nmi: fix timeout test in test_nmi_ipi()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 19, 2017 at 01:53:04PM +0300, Dan Carpenter wrote:
> We're supposed to exit the loop with "timeout" set to zero.
> 
> Fixes: 99e8b9ca90d6 ("x86, NMI: Add NMI IPI selftest")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Acked-by: Don Zickus <dzickus@xxxxxxxxxx>


> 
> diff --git a/arch/x86/kernel/nmi_selftest.c b/arch/x86/kernel/nmi_selftest.c
> index 6d9582ec0324..d27f8d84c4ff 100644
> --- a/arch/x86/kernel/nmi_selftest.c
> +++ b/arch/x86/kernel/nmi_selftest.c
> @@ -78,7 +78,7 @@ static void __init test_nmi_ipi(struct cpumask *mask)
>  
>  	/* Don't wait longer than a second */
>  	timeout = USEC_PER_SEC;
> -	while (!cpumask_empty(mask) && timeout--)
> +	while (!cpumask_empty(mask) && --timeout)
>  	        udelay(1);
>  
>  	/* What happens if we timeout, do we still unregister?? */
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux