This patch isn't right... On Wed, Jun 07, 2017 at 12:54:07AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > key has previously been null checked so the subsequent null check > is redundant as key can never be null at that point, so remove it. > Actually, it's the reverse. "key" is always NULL. Probably the || should be a &&? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html