On Wed, Jun 7, 2017 at 6:26 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The check on ret < 0 is redundant as the goto destination is the > next statment. Remove this redudant check and goto. > > Detected by CoverityScan, CID#1268785 ("Identical code for different > branches") > ret = max8925_reg_write(info->rtc, MAX8925_ALARM0_CNTL, 0x77); > else > ret = max8925_reg_write(info->rtc, MAX8925_ALARM0_CNTL, 0x0); > - if (ret < 0) > - goto out; > out: > return ret; ...and label (w/ replacing it by inplace return ret;) ? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html