Hi,
On Thu, May 18, 2017 at 10:43:46AM +0300, Dan Carpenter wrote:
> There are several cut and past bugs here. ltc3651_charger->charger is
> NULL at this point, so we return success instead of the intended error
> codes.
>
> Fixes: c94d4ed017ae ("power: supply: Add ltc3651-charger driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Thanks, queued.
-- Sebastian
> diff --git a/drivers/power/supply/ltc3651-charger.c b/drivers/power/supply/ltc3651-charger.c
> index 5f8d5c0b5721..eea63ff211c4 100644
> --- a/drivers/power/supply/ltc3651-charger.c
> +++ b/drivers/power/supply/ltc3651-charger.c
> @@ -110,21 +110,21 @@ static int ltc3651_charger_probe(struct platform_device *pdev)
> ltc3651_charger->acpr_gpio = devm_gpiod_get(&pdev->dev,
> "lltc,acpr", GPIOD_IN);
> if (IS_ERR(ltc3651_charger->acpr_gpio)) {
> - ret = PTR_ERR(ltc3651_charger->charger);
> + ret = PTR_ERR(ltc3651_charger->acpr_gpio);
> dev_err(&pdev->dev, "Failed to acquire acpr GPIO: %d\n", ret);
> return ret;
> }
> ltc3651_charger->fault_gpio = devm_gpiod_get_optional(&pdev->dev,
> "lltc,fault", GPIOD_IN);
> if (IS_ERR(ltc3651_charger->fault_gpio)) {
> - ret = PTR_ERR(ltc3651_charger->charger);
> + ret = PTR_ERR(ltc3651_charger->fault_gpio);
> dev_err(&pdev->dev, "Failed to acquire fault GPIO: %d\n", ret);
> return ret;
> }
> ltc3651_charger->chrg_gpio = devm_gpiod_get_optional(&pdev->dev,
> "lltc,chrg", GPIOD_IN);
> if (IS_ERR(ltc3651_charger->chrg_gpio)) {
> - ret = PTR_ERR(ltc3651_charger->charger);
> + ret = PTR_ERR(ltc3651_charger->chrg_gpio);
> dev_err(&pdev->dev, "Failed to acquire chrg GPIO: %d\n", ret);
> return ret;
> }
Attachment:
signature.asc
Description: PGP signature
