Re: rcu: Call mod_timer() correctly in wake_nocb_leader_defer()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 17, 2017 at 01:21:48PM -0700, Paul E. McKenney wrote:
> On Wed, May 17, 2017 at 10:44:46PM +0300, Dan Carpenter wrote:
> > Smatch complains that:
> > 
> > 	kernel/rcu/tree_plugin.h:1838 wake_nocb_leader_defer()
> > 	warn: mod_timer() takes an absolute time not an offset.
> > 
> > which is true.
> > 
> > Fixes: ebf7068a4396 ("rcu: Use timer as backstop for NOCB deferred wakeups")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> Good catch, and color me slow and stupid!!!
> 
> I will fold this into the original commit with the following attribution:
> 
> [ paulmck: Dan Williams fix for mod_timer() bug detected by smatch. ]
> 
> Does that work for you?

Not really, no.  If you changed the Williams to Carpenter, then it's
fine, though.  ;)

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux