On Wed, May 17, 2017 at 6:35 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Req is never null on at the point of the null check, so > remove this redundant check and just return &req->tx. > > Detected by CoverityScan, CID#1436147 ("Logically dead code") > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Hi Colin, Looks good, can you also include the driver name in your patch subjects? For example "dmaengine, bcm-scm-raid: remove redundant null check on req", would make it clear that this is a driver fix and not a core dmaengine issue. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html