From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Tue, 16 May 2017 19:05:36 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/sh/clk/cpg.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/sh/clk/cpg.c b/drivers/sh/clk/cpg.c index f23464bbeb7c..b3afe5c4fa3b 100644 --- a/drivers/sh/clk/cpg.c +++ b/drivers/sh/clk/cpg.c @@ -253,7 +253,5 @@ static int __init sh_clk_div_register_ops(struct clk *clks, int nr, - if (!freq_table) { - pr_err("%s: unable to alloc memory\n", __func__); + if (!freq_table) return -ENOMEM; - } for (k = 0; !ret && (k < nr); k++) { clkp = clks + k; @@ -474,7 +472,5 @@ int __init sh_clk_fsidiv_register(struct clk *clks, int nr) - if (!map) { - pr_err("%s: unable to alloc memory\n", __func__); + if (!map) return -ENOMEM; - } /* clks[i].enable_reg came from SH_CLK_FSIDIV() */ map->phys = (phys_addr_t)clks[i].enable_reg; -- 2.13.0 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
