On 12 May 2017 at 12:53, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Fri, 12 May 2017 20:36:03 +0200 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/hwtracing/coresight/coresight-etb10.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c > index d5b96423e1a5..7096c4562e15 100644 > --- a/drivers/hwtracing/coresight/coresight-etb10.c > +++ b/drivers/hwtracing/coresight/coresight-etb10.c > @@ -278,8 +278,7 @@ static void *etb_alloc_buffer(struct coresight_device *csdev, int cpu, > if (cpu == -1) > cpu = smp_processor_id(); > node = cpu_to_node(cpu); > - > - buf = kzalloc_node(sizeof(struct cs_buffers), GFP_KERNEL, node); > + buf = kzalloc_node(sizeof(*buf), GFP_KERNEL, node); I'm fine with this change but if it's going to happen, it has to be in all the coresight drivers and not just this one - please respin with all instances fixed. One patch per driver would be much appreciated. Thanks, Mathieu > if (!buf) > return NULL; > > -- > 2.12.3 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
