This looks spurious to iounmap resources in the normal path of this init function. The 3 ioremap'ed fields of 'pm_config' can be accessed later on in other functions, so it is likely that we should return 'success' before unrolling everything. Fixes: aa9aa1ec2df6 ("ARM: davinci: PM: rework init, remove platform device") Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> --- This patch is just a *guess*. The end of the function looks more like a error handling code rather than a normal path. --- arch/arm/mach-davinci/pm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-davinci/pm.c b/arch/arm/mach-davinci/pm.c index d282b0783ecf..163d865abbf9 100644 --- a/arch/arm/mach-davinci/pm.c +++ b/arch/arm/mach-davinci/pm.c @@ -161,6 +161,7 @@ int __init davinci_pm_init(void) davinci_cpu_suspend_sz); suspend_set_ops(&davinci_pm_ops); + return 0; no_sram_mem: iounmap(pm_config.ddrpsc_reg_base); -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html