Hi, On Friday, April 28, 2017 05:53:34 PM Tejun Heo wrote: > Hello, > > On Tue, Apr 18, 2017 at 10:00:37PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > Date: Tue, 18 Apr 2017 21:54:32 +0200 > > > > A few update suggestions were taken into account > > from static source code analysis. > > Hmmm, allocs -> callocs. Are these actually beneficial? If so, why? > Because one multiplication is rolled into the call? Each conversion (i.e. I tried the one from patch #1) seems to add an extra 24 bytes to the resulting code size (using gcc 4.8.4 for ARM32 cross-compilation) so I don't see much point in the automatic conversions. Only instances containing size calculations with real possibility for integer overflows should be converted and the patchset under discussion contains no such instances. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
