On Tue, May 09, 2017 at 10:27:20AM +0300, Dan Carpenter wrote: > On Sun, May 07, 2017 at 04:40:38AM +0900, Stafford Horne wrote: > > Hi Christophe, > > > > On Sat, May 06, 2017 at 10:23:59AM +0200, Christophe JAILLET wrote: > > > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > > > Return -ENOMEM instead, as done for the other memory allocation just a > > > few lines below. > > > > This looks fine. > > > > > BTW, change the 'devm_kzalloc' into a 'devm_kcalloc'. > > > > Any reason for the devm_kcalloc change? It looks like the next for loop > > does set all of the group_name values. > > > > The advantage of kcalloc() over kzalloc() is the integer overflow > checking. There is kmalloc_array() if we don't need to zero the memory. Right, usually its good to have a reason why in the commit log. i.e. BTW, change the 'devm_kzalloc' into a 'devm_kcalloc' for overflow checking. Or switch to devm_kmalloc_array() and say: for overflow checking and no need for zeroing. -Stafford -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
