On Fri, May 05, 2017 at 05:14:15PM +1000, Andrew Donnellan wrote: > sem is a global and it looks like it's intended to be held after > device_open() returns and only released in device_close(), so this looks > wrong. > This doesn't affect the success path, it only means that if device_open() fails because we don't have enough free memory or whatever then we can try again later. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html