On 05/03/17 12:49, Dan Carpenter wrote: > Static checkers complain that we should unlock before returning. Which > is true. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index 12597ff8cfb0..425338d6286d 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -2210,14 +2210,14 @@ static __init void of_unittest_overlay_high_level(void) > unittest(0, > "duplicate property '%s' in overlay_base node __symbols__", > prop->name); > - return; > + goto err_unlock; > } > ret = __of_add_property_sysfs(of_symbols, prop); > if (ret) { > unittest(0, > "unable to add property '%s' in overlay_base node __symbols__ to sysfs", > prop->name); > - return; > + goto err_unlock; > } > } > } > @@ -2232,6 +2232,10 @@ static __init void of_unittest_overlay_high_level(void) > > unittest(overlay_data_add(2), > "Adding overlay 'overlay_bad_phandle' failed\n"); > + return; > + > +err_unlock: > + mutex_unlock(&of_mutex); > } > > #else > Thanks Dan. Reviewed-by: Frank Rowand <frank.rowand@xxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html