Hi Colin, > Am 03.05.2017 um 12:33 schrieb Colin King <colin.king@xxxxxxxxxxxxx>: > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The function twl4030_bci_property_is_writeable can be made static > as it does not need to be in global scope. Indeed. Have tested and it still works. > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/power/supply/twl4030_charger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c > index abd10f6861ae..2f82d0e9ec1b 100644 > --- a/drivers/power/supply/twl4030_charger.c > +++ b/drivers/power/supply/twl4030_charger.c > @@ -943,7 +943,7 @@ static int twl4030_bci_set_property(struct power_supply *psy, > return 0; > } > > -int twl4030_bci_property_is_writeable(struct power_supply *psy, > +static int twl4030_bci_property_is_writeable(struct power_supply *psy, > enum power_supply_property psp) > { > switch (psp) { > -- > 2.11.0 > Thanks and BR, Nikolaus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html