On Tue, May 02, 2017 at 07:58:11PM +0200, Marcel Holtmann wrote:
> Hi Dan,
>
> > We should check to see if this kmalloc() fails.
> >
> > Fixes: e7c404c96c74 ("Bluetooth: allocate data for kpp on heap")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >
> > diff --git a/net/bluetooth/ecdh_helper.c b/net/bluetooth/ecdh_helper.c
> > index 80184476ff74..c8535845813d 100644
> > --- a/net/bluetooth/ecdh_helper.c
> > +++ b/net/bluetooth/ecdh_helper.c
> > @@ -59,11 +59,15 @@ bool compute_ecdh_secret(const u8 public_key[64], const u8 private_key[32],
> > struct ecdh p;
> > struct ecdh_completion result;
> > struct scatterlist src, dst;
> > - u8 *tmp = kmalloc(64, GFP_KERNEL);
> > + u8 *tmp;
> > u8 *buf;
> > unsigned int buf_len;
> > int err = -ENOMEM;
> >
> > + tmp = kmalloc(64, GFP_KERNEL);
> > + if (!tmp)
> > + goto out;
> > +
>
> I thought that I already fixed this. Is this issue still present in bluetooth-next tree?
>
Ah yeah. You already fixed this.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
