>> @@ -334,8 +334,8 @@ static int asoc_simple_card_parse_aux_devs(struct device_node *node, >> if (n <= 0) >> return -EINVAL; >> >> - card->aux_dev = devm_kzalloc(dev, >> - n * sizeof(*card->aux_dev), GFP_KERNEL); >> + card->aux_dev = devm_kcalloc(dev, n, sizeof(*card->aux_dev), >> + GFP_KERNEL); > > Do you realize that this change has absolutely no value We can have different software development opinions about such a source code adjustment. Does it improve the indentation for the parameters which are passed to this function call? > and just makes the code slower (one more test in the allocation path)? Do we stumble on a target conflict for the shown implementation detail? Does the previous size calculation contain the general possibility for an integer overflow? https://cwe.mitre.org/data/definitions/190.html The value for the variable “len” (and also “n”) might be small enough so that the computed value will usually not exceed the data type limit in this use case. Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
