Re: [PATCH] staging: speakup: Replace simple_strtoul by kstrtoul

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Shekhar Bhandakkar, on jeu. 27 avril 2017 22:10:32 +0530, wrote:
> The simple_strtoul function is obsolete.
> This patch replaces it by kstrtoul.

> @@ -153,7 +154,9 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
>  			continue;
>  		}
>  
> -		index = simple_strtoul(cp, &temp, 10);
> +		err = kstrtoul(cp, 10, &index);

Again, that doesn't update the temp pointer, which is used below.
So really NACK from me.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux