Hi Dan On Fri, 2017-04-21 at 13:39 +0300, Dan Carpenter wrote: > We should unlock before returning. > > Fixes: eda50cde58de ("iwlwifi: pcie: add context information support") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c > index 302310dfef9e..4e84955d55c8 100644 > --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c > +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c > @@ -212,8 +212,10 @@ int iwl_trans_pcie_gen2_start_fw(struct iwl_trans *trans, > goto out; > } > > - if (iwl_pcie_ctxt_info_init(trans, fw)) > - return -ENOMEM; > + if (iwl_pcie_ctxt_info_init(trans, fw)) { > + ret = -ENOMEM; > + goto out; > + } > > /* re-check RF-Kill state since we may have missed the interrupt */ > hw_rfkill = iwl_trans_check_hw_rf_kill(trans); Thanks for your patch! But this has already been fixed by Johannes in the patch I sent out yesterday[1]. [1] https://www.spinics.net/lists/linux-wireless/msg161582.html -- Cheers, Luca.��.n��������+%������w��{.n����z�ޗ�����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�