Re: [bug report] r8169: fix offloaded tx checksum for small packets.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 20, 2017 at 02:03:17AM +0200, Francois Romieu wrote:
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> :
> [...]
> > The patch b423e9ae49d7: "r8169: fix offloaded tx checksum for small
> > packets." from May 18, 2013, leads to the following static checker
> > warning:
> > 
> > 	drivers/net/ethernet/realtek/r8169.c:7165 rtl8169_start_xmit()
> > 	warn: passing freed memory 'skb'
> [...]
> >   7164          if (!tp->tso_csum(tp, skb, opts)) {
> >   7165                  r8169_csum_workaround(tp, skb);
> >                                                   ^^^
> > But the caller is not expecting it to be freed.
> 
> r8169.c as of b423e9ae49d7 was fine.
> 
> The caller was introduced in e974604b453e87f8d864371786375d3d511fdf56.
> 

Ah yes.  You're right.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux